James Pearce

Results 63 comments of James Pearce

I'm hanging out here but take it out of draft when you want me to take a final look

Hey @bndkt is this ready? 😄 - do you want me to review and/or rebase this for you?

OK I'll take a look! I found some broken tests in the v5 beta branch and this might be similar. Leave it with me.

@bndkt please take a look at https://github.com/tinyplex/tinybase/pull/133/commits/51f1a2989e0dbafa87135cd40aec6f28566c44d4 - I simplified and isolated a simple (JSON-based) test that fails. The second write to the table (that has `"c1":2`) does not fire...

@bndkt a gentle ping to see if you have any thoughts on this mock issue

OK, I fixed it. There was something strange about adding and removing event listener references on the database. The solution was `removeAllListeners` in the mock. Should all pass 100%. Think...

Alright! Let's do any final polish in `main`.

Thanks so much for your work on this!

Great analysis. I'm a bit surprised that undefined throws (the Store should ignore invalid content silently) but I'm sure you're right. Once I repro, I'll make sure that _is_ the...

I can't get it to throw, per se... it appears as an ignored error: ```js test.only('does not error on getPersister returning undefined', async () => { const store = createStore();...