James C. Davis
James C. Davis
This is out of scope for this PR, but should we update this example https://github.com/ember-template-lint/ember-template-lint/blob/ba97a8737ad1dcd26fd225e5639f155b59589981/docs/ignore.md?plain=1#L16-L21 to no longer duplicate ignores and remove https://github.com/ember-template-lint/ember-template-lint/blob/ba97a8737ad1dcd26fd225e5639f155b59589981/docs/ignore.md?plain=1#L25-L33 now that `ember-cli-template-lint` is deprecated?
Also https://github.com/ember-template-lint/ember-template-lint/blob/ba97a8737ad1dcd26fd225e5639f155b59589981/docs/ignore.md?plain=1#L35 should probably be removed at this point, regardless.
@csprocket777 what version of ember-basic-dropdown and ember-maybe-in-element do you have? I think you need at least 3.0.8 so that you get https://github.com/cibernox/ember-basic-dropdown/commit/e89a00e0dbdd1226bf6732b8500a3df62097a25d
You shouldn't have to (it's already a dep of `ember-basic-dropdown`). It's possible something regressed since https://github.com/glimmerjs/glimmer-vm/pull/1204
🤔 `ember try:one ember-release` fails for me locally. AFAICT CI is not actually running for this repo.
I am seeing the same, but with ember-basic-dropdown 1.x (can't upgrade to latest because our app is on Ember 3.12 and can't upgrade just yet).
Ok, there was some issue with `ember-font-awesome` in the test suite. I removed it and the `{{fa-icon}}` invocations in tests and the test suite builds and runs on ember-release (3.25)....
Thank you for taking the time to get CI going again, @cibernox!
Oops, my `@glint-expect-error` directives messed up tests. I'll fix.
I have a need for this too. For example, I'd like to tighten up the type for QUnit's [assert.ok](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/88413c58a13c33bea51f06a0a0d2aa09bd93b1d2/types/qunit/index.d.ts#L166) to ```ts ok(state: boolean, message?: string): void; ``` in a project...