James Liu

Results 428 comments of James Liu

> I had a look at that but since there's no `Rect` equivalent for `UVec2` I wasn't confident in changing it. I'm not sure where to put the `URect` struct...

@maniwani thanks for helping wordsmith the docs here. Might need to update guidance on our general docs guidance to match. > Also, side note, maybe we should rename these to...

Can confirm that the latest winit update has fixed this on Windows.

Could we separate this from #7188? It's unclear if we want to merge those two, and I would like for this redundancy to be removed.

Moving this to 0.11 as it seems like we're going to be shipping 0.10 early today, and this isn't ready yet for a merge.

Looks like `once_cell` uses the 2021 edition, which has a MSRV of 1.56. Is this acceptable to bump the MSRV of this crate? or should I instead pin an earlier...

@hawkw ping about this question

With `syn 2.0.0` coming out bumping it's MSRV to 1.56, there's likely a bunch of crates bumping their MSRVs soon. Went ahead and updated the MSRV, added a `rust_version` field...

Also bumped the edition to 2021.

Loom seems to dislike `once_cell`'s Lazy implementation. It's apparently unsupported right now, see https://github.com/tokio-rs/loom/issues/263.