James Liu
James Liu
I have a similar minimal Arch box lying around somewhere, will test this soon.
Marking this as blocked on a potential wgpu release, since this otherwise would add complexity without any gains.
The changes to the APIs are technically breaking changes. Could you document them in a Migration Guide section?
> It's not a breaking change I don't think, as the lifetimes should be inferred for most use cases. This adds an argument to `RenderGraphRunner::run`. I don't expect many people...
Holding off on taking this out of draft until #8053 is merged since some of the optimizations using inlined `Entities::get` and `Entities::set` relies on the unwrap when handling bundles to...
Found a few more: - [UnsafeWorldCell::get_entity](https://github.com/james7132/bevy_asm_tests/blob/main/results/world_get.s#L41) - [UnsafeWorldCell::world_metadata](https://github.com/james7132/bevy_asm_tests/blob/main/results/world_get.s#L47) - [UnsafeWorldCell::unsafe_world](https://github.com/james7132/bevy_asm_tests/blob/main/results/world_get.s#L109)
Found yet more: - [World::as_unsafe_world_cell](https://github.com/james7132/bevy_asm_tests/blob/main/results/world_get_sparse.s#L35) - [SparseSets::get](https://github.com/james7132/bevy_asm_tests/blob/main/results/world_get_sparse.s#L111) - [Various SparseSetIndex implementations](https://github.com/james7132/bevy_asm_tests/blob/main/results/world_get_sparse.s#L120)
> Is there an impact on build time with those new inlines? Good question.Definitely worth measuring. I would assume it would increase the amount of generated code whenever larger functions...
@mockersf I checked the compiler output changes for this PR: https://github.com/james7132/bevy_asm_tests/commit/214de16807d1d33eeb8f7434fdc7e0f766ae1053 Seems like there's a slight increase in codegen (~100-170 instructions) for component insertion/removal, and a signifcant decrease for any...