Add optional limit argument to get_block

[c0j0s]

trafficstars

#292

although setting a new fixed limit works, adding an optional limit argument would be better if notion decide to change the query limit in the future.

[dorileo]

Well, overall the PR looks good. +1

[xiantang]

@jamalex plz take a look!

[accounts01]

this is a pretty paralyzing issue. does anyone know how long it will take for it to get merged in?

[gnestor]

this is a pretty paralyzing issue. does anyone know how long it will take for it to get merged in?

In the meantime, you can pip install git+https://github.com/jamalex/notion-py.git@refs/pull/294/merge or replace notion-py with git+https://github.com/jamalex/notion-py.git@refs/pull/294/merge in your requirements.txt. I have tested and this fixed my issues 👍

[accounts01]

thanks a lot @gnestor! that's exactly what i needed :) and it's so much cleaner than fiddling with the code in site-packages which is what i ended up doing 🙈

[younho9]

Thanks a lot @gnestor! pip install git+https://github.com/jamalex/notion-py.git@refs/pull/294/merge command installs specific versions of git repo on notion-py well.

However, I have problem using setuptools to specify the merge version of the git repo as dependency in my python package.

Referring to the this link, the install_requires specified as follows, but this does not work properly.

setuptools.setup(
    ...    
    install_requires=[
        "notion @ git+https://github.com/jamalex/notion-py.git@refs/pull/294/merge"
    ],
    ...
)

Could you help me with this problem by any chance?

[gnestor]

My setuptools chops are rusty, but try replacing notion @ git+https://github.com/jamalex/notion-py.git@refs/pull/294/merge with git+https://github.com/jamalex/notion-py.git@refs/pull/294/merge

[younho9]

I tried the following setup.py settings, but the following error occurs.

setuptools.setup(
    ...    
    install_requires=[
        "git+https://github.com/jamalex/notion-py.git@refs/pull/294/merge"
    ],
    ...
)

error in narkdown setup command: 'install_requires' must be a string or list of strings containing valid project/version requirement specifiers; Parse error at "'+https:/'": Expected stringEnd

Also, I have tried the following with this answer.

But this method has a problem when uploading to pypi.

HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/
Invalid value for requires_dist. Error: Can't have direct dependency: 'notion @ git+https://github.com/jamalex/notion-py.git@refs/pull/294/merge'

I need to find a way to set git repo to direct dependence when uploading to pypi.

[gnestor]

It looks like your original approach was the right way to do it in setuptools but I'm not sure how you can point to a git ref...

[younho9]

I also couldn't find a way to upload a package that have a git repo as a dependency to pypi.

Instead, I solved the problem by importing the git forked version directly.

Thank you for your reply.

[vzts]

Hi @jamalex Can it be merged?

[miletoda]

Have you find the way to load/read more than 100 records at a time?

[es-arif]

Please audit and merge if possible. This is affecting many users!

This is stretching out to StackOverFlow

[paulaceccon]

Thanks a lot @gnestor! pip install git+https://github.com/jamalex/notion-py.git@refs/pull/294/merge command installs specific versions of git repo on notion-py well.

However, I have problem using setuptools to specify the merge version of the git repo as dependency in my python package.

Referring to the this link, the install_requires specified as follows, but this does not work properly.

setuptools.setup(
    ...    
    install_requires=[
        "notion @ git+https://github.com/jamalex/notion-py.git@refs/pull/294/merge"
    ],
    ...
)

Could you help me with this problem by any chance?

Use the commit:

notion@git+https://github.com/jamalex/notion-py.git@fe8ac41e1c10a229c040bd7cadd9429a66fbcda3

[andrewspode]

Is there a reason this hasn't been merged in yet? It's breaking lots of things :)

[fanuch]

FWIW I have started moving all my code across to the official Notion API. May not have feature parity but it will get there.

Sick of sourcing on a PR for a fix.

[tyePhDCandy]

I run the code to install commit with pip, but setup.py error occurred.

I run the following code, with hash code of this commit.

# fe8ac41e1c10a229c040bd7cadd9429a66fbcda3 is the hash code of this commit.
pip install git+https://github.com/jamalex/notion-py.git@fe8ac41e1c10a229c040bd7cadd9429a66fbcda3

I get an error related to setup.py.

Collecting git+https://github.com/jamalex/notion-py.git@fe8ac41e1c10a229c040bd7cadd9429a66fbcda3
  Cloning https://github.com/jamalex/notion-py.git (to revision fe8ac41e1c10a229c040bd7cadd9429a66fbcda3) to c:\users\uotik\appdata\local\temp\pip-req-build-g11n7s9k
  Running command git clone --filter=blob:none --quiet https://github.com/jamalex/notion-py.git 'C:\Users\uotik\AppData\Local\Temp\pip-req-build-g11n7s9k'
  Running command git rev-parse -q --verify 'sha^fe8ac41e1c10a229c040bd7cadd9429a66fbcda3'
  Running command git fetch -q https://github.com/jamalex/notion-py.git fe8ac41e1c10a229c040bd7cadd9429a66fbcda3
  Running command git checkout -q fe8ac41e1c10a229c040bd7cadd9429a66fbcda3
  Resolved https://github.com/jamalex/notion-py.git to commit fe8ac41e1c10a229c040bd7cadd9429a66fbcda3
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [6 lines of output]
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "C:\Users\uotik\AppData\Local\Temp\pip-req-build-g11n7s9k\setup.py", line 4, in <module>
          long_description = fh.read()
      UnicodeDecodeError: 'gbk' codec can't decode byte 0x92 in position 11951: illegal multibyte sequence
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

[emmby]

@c0j0s or @jamalex Can you re-open this PR? Many of us are linking directly to the PR in our pip requirements.txt, and my deployments are now failing now that the PR is closed.

Context: https://stackoverflow.com/a/55959742/82156

[c0j0s]

@c0j0s or @jamalex Can you re-open this PR? Many of us are linking directly to the PR in our pip requirements.txt, and my deployments are now failing now that the PR is closed.

Context: https://stackoverflow.com/a/55959742/82156

I closed this PR as it was included in #352 and was merged into the master branch.

I'll reopen it again, didn't realise closing this would have such side effect.

[emmby]

Even better, I didn't realize the changes had been merged in elsewhere. I'll switch to head, ty!