Jake Ireland

Results 70 comments of Jake Ireland

- [ ] See also https://github.com/Simon-Hohberg/Viola-Jones/compare/master...najiji:master (from https://github.com/najiji/Viola-Jones)

- [x] On top of this, need to consider performance: https://docs.julialang.org/en/v1.5/manual/performance-tips/

- [ ] Also consider using `axes` rather than plain referencing (for n dimensional images): https://julialang.org/blog/2017/04/offset-arrays/ That is to say ```julia # Yes: for x in axes(img_arr, 1) # No:...

Regarding comment made on 3rd September, these are the commits which I haven't yet assessed (those commits which seem to seriously change the AdaBoost method): - [ ] https://github.com/Simon-Hohberg/Viola-Jones/commit/bd9520a4865b7976d0da00abf83c9c5328026699 -...

Assigning @dmipeck to help with this. Not pressing as the algorithm detects faces and non-faces above chance, so the algorithm works, despite the lack of peer review.

I have added ```julia FaceDetection.notifyUser("Loading test faces...") facesTesting = FaceDetection.loadImages(posTestingPath) # facesIITesting = map(FaceDetection.toIntegralImage, facesTesting) facesIITesting = map(i -> imresize(i, (19,19)), map(FaceDetection.toIntegralImage, facesTesting)) println("...done. ", length(facesTesting), " faces loaded.") FaceDetection.notifyUser("Loading...

After f9b07196, I began to benchmark results of the `basic.jl` compared to Simon Hohberg's `example.py`. However, when I started this, I realised — something I had forgotten before now —...

[[ef4015fe](https://github.com/jakewilliami/FaceDetection.jl/commit/ef4015fed1b12c6d9053f90a94e21a47e82a311e)] There was another copy error, which changed results: ```julia # Previous results Faces: 312/472 (66.10169491525424% of faces were recognised as faces) Non-faces 12894/19572 (65.87982832618026% of non-faces were identified as...

POC: ```rust pub fn local_ip() -> Result { let sock_addr = SocketAddr::new(IpAddr::V4(Ipv4Addr::new(8, 8, 8, 8)), 80); let socket = UdpSocket::bind("0.0.0.0:0").expect("Could not bind to address"); match socket.connect(sock_addr) { Ok(_) => Ok(socket.local_addr().unwrap().ip()),...

+1, I came here to suggest it too. They key values in this package should definitely support IntervalSets.jl.