Jake Vanderplas
Jake Vanderplas
Looks like there are some lint issues with whitespace. You can fix these locally by running `pre-commit`: https://jax.readthedocs.io/en/latest/contributing.html#linting-and-type-checking
Yeah, removing all trailing whitespace should fix the error. Regarding the `pre-commit` installation error, it's probably some kind of version incompatibility. Hard to say without seeing more of the error...
It seems like some other commits snuck into your PR! It looks like you both rebased and merged, but targeted different snapshots of the `main` branch. I'd try fixing it...
It seems like some other commits snuck into your PR! It looks like you both rebased and merged, but targeted different snapshots of the `main` branch in each operation. I'd...
Good catch! Are you interested in putting together a PR with the fix? If not one of the team members can take care of it. Thanks!
Good catch, thanks for the fix! One minor suggestion: rather than new specific test cases, we could add relevant cases to the old tests. For example here: https://github.com/google/jax/blob/64bd95ded50fc647d6e80a55ab1cb3baef368cf6/tests/lax_numpy_reducers_test.py#L664 and here:...
I looked at `user_context`, but it wasn't clear that it was the right tool. We have to save an earlier stack (which is not associated with any exception) and print...
Thanks for the context... I'm not sure, but I'll explore that idea a bit
It's not clear to me how the approach in `user_context` could be used in this case, because we don't have any traceback from the original usage location. Can you be...
@froystig I updated the code to use existing exception chaining mechanisms – PTAL, and see the updated example output in the description.