Jacob MacDonald

Results 1518 comments of Jacob MacDonald

Optional builders still have nodes in the graph - they just might not be built.

(fwiw, ddc/summaries/modules have always been optional, or at least for a long time)

Most likely we just need to pass `--no-source-maps` to dart2js, today the only default flag is `--minify`.

Should we also enable using these aliases when statically configuring a builder somehow?

What if you want to only apply an option set in a specific mode though? Do we support debug_option_sets etc? lol

Yes - if running on node then you need to use `build_node_compilers` and not `build_web_compilers`. If you want to run both in the same project, you will need to configure...

> In my case, tests are exactly the same for both runtimes so it would be nice for build_runner to handle that source duplication automatically. The builders themselves need to...

> I thought that there could be (at some point) a "test_builder" that takes _test.dart files and produces _node_test.dart and _web_test.dart depending on those package:test selectors. Yes - this is...

Note though that the issue here isn't that those files always get created - its that both packages are trying to compile the original test.

> In addition to that, in the first failure case, package:test tries to run tests compiled with build_web_compilers on node. You actually got a load error here - the issue...