Jake Kidd

Results 27 comments of Jake Kidd

- domain indexer and queue still need forge unit tests working on that on branch `lib-message-tests`, which also includes a fix for: https://hackmd.io/@-HV50kYcRqOjl_7du8m1AA/HJbJOh6Go#Finding-MerklebranchRoot-can-attribute-a-leaf-to-its-root-at-multiple-indices ![image](https://user-images.githubusercontent.com/37907740/195938519-cbb5cae1-eb95-404e-b35a-65d5135a9556.png)

- "iff delay block == 0, just skip the whole validation queue" needs an issue opened

- looks like we are doing a redundant verification period check with the mainnet spoke connector (separate from above issue) ![image](https://user-images.githubusercontent.com/37907740/195938863-6c7182a5-f40d-4759-87e0-be6c4962e9c4.png)

- delay block needs for validation period technically could vary on a chain by chain basis. rollups, for example, don't even need verification period (for one of the directions, either...

two separate issues that are likely *both* out of scope. the first one is technically more pressing, but both are harmless sec-wise as far as I can tell, only are...

- inconsistent use of interface IERC20 in bridgefacet: noting this bc we literally use SafeERC20 for IERC20 under libraries in this contract

this should just be the offchain component, related to #1729 ~~should use the merkletreelib.js library to generate proofs~~ EDIT: should NOT use the merkletreejs library, see edited og comment