documentation icon indicating copy to clipboard operation
documentation copied to clipboard

Fixing a small typo

Open virtualandy opened this issue 1 year ago • 3 comments

Which problem is this PR solving?

Eek, I didn't create an issue since this was such a small change. I can definitely do that if needed!

Description of the changes

Just fixing a typo.

How was this change tested?

I didn't run locally 😭 since just a typo fix.

Checklist

  • [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
  • [x] I have signed all commits
  • [ ] I have added unit tests for the new functionality
  • [ ] I have run lint and test steps successfully
    • for jaeger: make lint test
    • for jaeger-ui: yarn lint and yarn test

virtualandy avatar Apr 19 '24 19:04 virtualandy

Deploy Preview for romantic-neumann-1959d7 ready!

Name Link
Latest commit fd1f651ec6fd1a16ab5a73550e4bb5c14d85aef4
Latest deploy log https://app.netlify.com/sites/romantic-neumann-1959d7/deploys/6623373ad955160008a8ae0f
Deploy Preview https://deploy-preview-694--romantic-neumann-1959d7.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 19 '24 19:04 netlify[bot]

The typo is in versions 1.56 and earlier - if I got this wrong by editing next-release let me know and I'm happy to fix it up!

virtualandy avatar Apr 19 '24 19:04 virtualandy

@yurishkuro oh, neat, didn't realize that was there (apologies, I should've read all the docs/setup flow first :) ). I made an update to that word to see how it affects the build/tests. I'll scan it for other typos too.

virtualandy avatar Apr 20 '24 03:04 virtualandy

Looks like this was fixed with https://github.com/jaegertracing/documentation/pull/704

virtualandy avatar Jul 02 '24 16:07 virtualandy