Jacob Walls comments

Results 503 comments of


                                            Jacob Walls

Fix setuptools>=64 import hooks

Sorry for not prioritizing this yet. @DanielNoord would you be able to write a (short) summary of why you believe this is the correct approach? That would help me get...

Fix setuptools>=64 import hooks

Also, I noticed two failures in pylint with this change, including one crash and one `astroid-error`: ```py pytest -k private-import Exception on node in file '/Users/.../pylint/tests/functional/ext/private_import/private_import.py' Traceback (most recent call...

Fix setuptools>=64 import hooks

Interesting that the failure is coming from `pytest` itself.

Fix setuptools>=64 import hooks

> That's why I'm debating on moving the check for known MetaPathFinders to above line 372, in _find_spec_with_path. That should resolve this I think. I'd be curious to see the...

dev/7.0.x Bug Display of the Correct Language for the "Unpublish Graph" button

This string is marked for localization now.

Ensure url and url_label are always props on url value, re #8451

New effort in #10642

[MU4 Issue] Mac "open -a ...mscore filename.ext" ignores file

I can reproduce with @mscuthbert's instructions on every attempt.

Prevent splitting of textarea's closing tag

The underlying issue also affects the `` tag, see [playground](https://prettier.io/playground/#N4Igxg9gdgLgprEAuEAeeBbADgGwIbwB8AOlAARmoDOWeUpFFSY+VVAvMSA4xVThBgAFAE4QsVAHRQIAEziSA1nACeZdhrIYIANwCWUAOYBJTEtU9eFAPxkA5HqoBaPLIBWAVyowDhp7REEGDtLKyR7EPJGLh4SKIoADVQAeho6OJTMXAI4OJAAGhBxH2gqZFA8ETEAdyFKhDKUPBxqvBUywoAjETwwZRgAZTwMOAAZAzhkADNmqjgunr64QdowX2QYEQ95kDmMPQ2tnbgADyw4ET0R2GaAFQuoSr04RpmcOcKqXxw4AEUPQSTJBvD4gNxUE4Db5-AHwaazHYAR1hcFE4kaIDwzigcDg8lkBRAmzwehwvgAwhAMBg8MhMTgcISvkYfgBBGCbPSdDzwIQXcY4w7bQoACxgGBwAHURXp4GkwHABg1ZXp9DAVHSwGxCTptsYoPJYAMwJcsDBWQaBuqfvD3jssGI5pKelg6Q6XhcdJNCgY5iJhD1DDTbaCAn66brvSAHQYYJK9LIYCLkAAOAAMhUCyL0gVEeCDtOBCMKMDwnXjieTSAATIUvHBbmXXsWQHAMJ08fjRnRDB583AAGIQEQ0jnrJo8iAgAC+06AA)

Closing tag is split for long tag names and long lines.

Also affects the `` tag: [playground](https://prettier.io/playground/#N4Igxg9gdgLgprEAuEAeeBbADgGwIbwB8AOlAARmoDOWeUpFFSY+VVAvMSA4xVThBgAFAE4QsVAHRQIAEziSA1nACeZdhrIYIANwCWUAOYBJTEtU9eFAPxkA5HqoBaPLIBWAVyowDhp7REEGDtLKyR7EPJGLh4SKIoADVQAeho6OJTMXAI4OJAAGhBxH2gqZFA8ETEAdyFKhDKUPBxqvBUywoAjETwwZRgAZTwMOAAZAzhkADNmqjgunr64QdowX2QYEQ95kDmMPQ2tnbgADyw4ET0R2GaAFQuoSr04RpmcOcKqXxw4AEUPQSTJBvD4gNxUE4Db5-AHwaazHYAR1hcFE4kaIDwzigcDg8lkBRAmzwehwvgAwhAMBg8MhMTgcISvkYfgBBGCbPSdDzwIQXcY4w7bQoACxgGBwAHURXp4GkwHABg1ZXp9DAVHSwGxCTptsYoPJYAMwJcsDBWQaBuqfvD3jssGI5pKelg6Q6XhcdJNCgY5iJhD1DDTbaCAn66brvSAHQYYJK9LIYCLkAAOAAMhUCyL0gVEeCDtOBCMKMDwnXjieTSAATIUvHBbmXXsWQHAMJ08fjRnRDB583AAGIQEQ0jnrJo8iAgAC+06AA)

pylint lacks type-narrowing control-flow knowledge from `isinstance`

> However, I'll leave this issue open as the PR doesn't implement control-flow logic. I'm going to suggest treating this issue as the top-level duplicate for requests to understand type-narrowing...