Jacob Walls

Results 508 comments of Jacob Walls

I think I'm still missing some context -- are you saying there are parts of HA that not only aren't covered by pytest, but aren't covered by pylint? Why not?

Thanks, that's helpful. I'm thinking we should ignore all the SyntaxWarnings in third-party code, with a caveat that we could check the current state of the warnings filters, and whatever...

Thanks for the report. The undefined-variable is reported in #9335, so I'll refocus this report on the unsubscriptable-object.

This change was made in #4764 to address false positives where the `if` guards are performing a type-narrowing function. There are two follow-ups I see immediately from your report, though....

Reproduced @ 51c28bc922dfb8da42e680ed7190eb942889df01 ```sh pylint --enable=missnig-docstring pylint/checkers/utils.py ************* Module Command line Command line:1:0: W0012: Unknown option value for '--enable', expected a valid pylint message and got 'missnig-docstring' (unknown-option-value) -------------------------------------------------------------------- Your...

Yep, exactly! This issue is ready for a contributor to tackle.

Agree we could extend the check to the last line of a (potentially nested) try/if/with

Thanks for the report! Slimmer reproducer without multiple bases: ```py class Window: ... class Win(Window): def __init__(self, txt): super().__init__(txt) Win('hello') ``` I'm assuming that this case is missed in this...

Thanks for the report. pylint-dev/astroid#1189 added an inference constraint for `is None`, but we should add one for boolean tests. For that reason, if you adjust the example to test...

Hi, thanks for the idea :wave: We already have `nested-min-max` for `min()` and `max()` -- was your proposal that we identify other standard library functions to extend this to?