confer icon indicating copy to clipboard operation
confer copied to clipboard

configReader should not call jww.Fatalf

Open MightyE opened this issue 9 years ago • 2 comments

In ./reader/configreader.go you call jww.Fatalf() which calls log.Fatalf() which calls os.Exit(1) which provides no opportunity for the parent program to recover from a configuration exception, even if done in a goroutine.

Recommend updating these jww.Fatalf() calls to jww.Panicf() so that the program can recover if they have a clean path to do so.

Happy to put together a pull request if you would like.

MightyE avatar Jan 18 '16 17:01 MightyE

I believe! Pull request would be appreciated.

jacobstr avatar Jan 29 '16 01:01 jacobstr

Here you go! @ #12

ianomad avatar Aug 19 '16 22:08 ianomad