node-gcm-ccs icon indicating copy to clipboard operation
node-gcm-ccs copied to clipboard

ack list is always increasing

Open nsiitk opened this issue 10 years ago • 2 comments

on receiving ack callback is retrieved from the ack[] but the list is always increasing. shouldn't executed cb be removed from ack[]. GCM spec says only 100 pending ack should be there in the ccs and this way can we manage the send message throttle

nsiitk avatar Oct 01 '15 04:10 nsiitk

I have changed acks to hash {} and delete acks[msgid] on ack and nack. I can share the code but I am running it with node 12.7 is that ok

nsiitk avatar Oct 01 '15 10:10 nsiitk

Should be fine! Send a pr.

jacobp100 avatar Oct 01 '15 11:10 jacobp100