serverless-plugin-git-variables icon indicating copy to clipboard operation
serverless-plugin-git-variables copied to clipboard

Published 20 hours ago • verified publisher icon jacob-meacham

Refactor to use NodeGit

Open iDVB opened this issue 6 years ago • 1 comments

Hey @jacob-meacham, Thanks for merging my PR!

I had another thought, that I may not get around to PR'n for a bit. But it would like be a good idea to refactor out all git CLI commands in favor of using something like NodeGit directly.

This will likely mean that the plugin would then work across OSs.

iDVB avatar Apr 08 '19 15:04 iDVB

@iDVB I'm definitely open to a PR doing this! In fact one of the only TODOs in the codebase is to do just that: https://github.com/jacob-meacham/serverless-plugin-git-variables/blob/a6a33f5acd1e06a34835c4c623ec0bb745a5cda7/src/index.js#L1

jacob-meacham avatar May 03 '19 23:05 jacob-meacham