django-rest-framework-datatables icon indicating copy to clipboard operation
django-rest-framework-datatables copied to clipboard

standardised params for get_queryset_count_before / after

Open matthewhegarty opened this issue 1 year ago • 2 comments

Extension to #149 which includes the params passed into the parent method. This is useful if the override of count needs to depend on other params.

Note this will break the interface released in 0.7.2, which means that anyone who has overridded get_queryset_count_before or get_queryset_count_after will have to update their code. We can change the param order or add kwargs to avoid this if required.

matthewhegarty avatar Jun 18 '24 12:06 matthewhegarty

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (2893b14) to head (7a60e85).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #150   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          427       427           
=========================================
  Hits           427       427           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jun 18 '24 12:06 codecov-commenter

Hi @izimobil - is it possible we can merge this? thanks

matthewhegarty avatar Jun 10 '25 11:06 matthewhegarty