redmine_tags
redmine_tags copied to clipboard
Tag permissions #168 reroll
Taken from https://github.com/ixti/redmine_tags/pull/168 and rebased it on current version.
Confirmed this is working as expected. Thanks to the original contributor!
I don't see any unit test in this PR. Have considered adding some ?
I'd say that security related things are quite important to be well tested.
Totally agree - I do need some help as I am not accustomed to write ruby or redmine plugins. We needed this functionality so I rerolled and tested it for our application.
See my latest comment in #168 It now also includes view permissions. But it's not yet tested properly. Unit tests are also missing