react-native-image-crop-picker icon indicating copy to clipboard operation
react-native-image-crop-picker copied to clipboard

[AOS] EXTRA_ALLOW_MULTIPLE multiple Options better plan suggestion.

Open sonic0987 opened this issue 3 years ago • 1 comments

Version

Tell us which versions you are using:

  • react-native-image-crop-picker v0.38.0
  • react-native v0.64.2

Platform

Tell us to which platform this issue is related

  • Android

Expected behavior

import ImagePicker from 'react-native-image-crop-picker';
...
...
ImagePicker.openPicker({
     mediaType: 'photo',
     multiple: true
})

it will be multiple select gallery images.

but,

Actual behavior

it can't select multiple gallery images.

because,

Steps to reproduce

  1. https://github.com/ivpusic/react-native-image-crop-picker/blob/master/android/src/main/java/com/reactnative/ivpusic/imagepicker/PickerModule.java#384 go to 384 line

AS-IS

galleryIntent.putExtra(Intent.EXTRA_ALLOW_MULTIPLE, multiple);

TO-BE

galleryIntent.putExtra(Intent.EXTRA_ALLOW_MULTIPLE, multiple);
if(multiple){
   galleryIntent.setData(MediaStore.Images.Media.EXTERNAL_CONTENT_URI);
}

Attachments

// stacktrace or any other useful debug info

Love react-native-image-crop-picker? Please consider supporting our collective: 👉 https://opencollective.com/react-native-image-crop-picker/donate

sonic0987 avatar Sep 15 '22 02:09 sonic0987

fix the code & release plz.

sonic0987 avatar Sep 15 '22 02:09 sonic0987

Any update ?

gokugen avatar Mar 10 '23 00:03 gokugen

Unfortunately, there doesn't seem to be an update. I wrote a post to argue that this is a bug. but I received no feedback.

sonic0987 avatar Jun 01 '23 13:06 sonic0987