react-native-image-crop-picker icon indicating copy to clipboard operation
react-native-image-crop-picker copied to clipboard

avoidEmptySpaceAroundImage iOS not working

Open mwegener-com opened this issue 4 years ago • 6 comments

Version

Tell us which versions you are using:

  • react-native-image-crop-picker v0.36.4?
  • react-native v0.63.4

Platform

Tell us to which platform this issue is related

  • iOS

Expected behaviour

It should be possible to show the full image in the crop-frame with empty space around the image

Actual behaviour

It's not possible to have empty space around the image

Steps to reproduce

  1. Set avoidEmptySpaceAroundImage to false

  2. Select image

  3. Try to zoom out

Attachments

await ImagePicker.openPicker({
			width: width,
			height: height,
			compressImageQuality: quality,
			mediaType: 'photo',
			cropping: true,
			loadingLabelText: language.LOADING,
			cropperChooseText: language.SELECT,
			cropperCancelText: language.CANCEL,
			forceJpg: true,
			avoidEmptySpaceAroundImage: false,
		})
			.then((image) => {
				imageURL = image.path;
			})
			.catch((reason) => console.log(reason));

https://user-images.githubusercontent.com/64470126/136706897-b5237cd5-c632-42a2-9d37-cbaf8f7a92a5.mov

mwegener-com avatar Oct 10 '21 17:10 mwegener-com

a duplicate of https://github.com/ivpusic/react-native-image-crop-picker/issues/1108?

SudoPlz avatar Oct 21 '21 19:10 SudoPlz

a duplicate of #1108?

I'm not sure if it is the same problem.

mwegener-com avatar Oct 21 '21 19:10 mwegener-com

I had the same issue and after some research I found out since v0.34.1, when the implementations was changed from RSKImageCropper to TOCropViewController, this prop doesn't work anymore, it's like a dummy prop xD

guiibussinger avatar Nov 22 '21 20:11 guiibussinger

I had the same issue and after some research I found out since v0.34.1, when the implementations was changed from RSKImageCropper to TOCropViewController, this prop doesn't work anymore, it's like a dummy prop xD

great! Can we just change it back? Do you have any solution?

mwegener-com avatar Nov 22 '21 20:11 mwegener-com

I didn't try change it back, since the version that still uses RSKImageCropper is from Sep 2020, I think it should work. Otherwise, I have not another solution yet.

guiibussinger avatar Nov 22 '21 20:11 guiibussinger

Hey guys, this one would be a very good feature to have. It seems that it is a regression caused by some changes regarding the underlying library

mathbalduino avatar May 25 '25 00:05 mathbalduino