ivmarkov
ivmarkov
Let's have two separate PRs for these if you don't mind. If you want to discuss or in general see what is going on - join the Matrix room which...
@Volkalex28 what happened? Are you still interested in contributing a PR?
No rush. It is just that we are prepping for a release these days, so if you want the fixes to go in, you might need to hurry up. But...
@Vollbrecht I've avoided the VFS stdout/in/err redirection topic for a long time, because it is complex. However, if we are to introduce some control w.r.t. blocking vs non-blocking IO, I...
@Vollbrecht I'm browsing the VFS code all morning (particularly the UART and USB-SERAL/JTAG "VFS" "drivers") and it is even more complex than I thought. Let's not rush the idea of...
It seems the way how UART, JTAG and USB-CDC operate as "files" in the VFS layer is fundamentally incompatible with our notion of `Peripherals` and in partuclar, that a certain...
> The primary two goal's of the API should be the following: > > * Provide a more discoverable place compared to the shedful of different places a user needs...
The outstanding comments to this PR were addressed and merged as the following 3 PRs: https://github.com/esp-rs/esp-idf-hal/pull/504 https://github.com/esp-rs/esp-idf-svc/pull/541 https://github.com/esp-rs/esp-idf-svc/commit/127de023f6d9943f567210621b8fc68d611918f1
The one deivation from your original approach is that I implemented a more heavyweight one, where the user has to provide a full-blown `UartDriver` or `UsbSerialDriver` (yes, we have this...
And even though I mentioned the other day in the forums that we'll fix the default UART0 pins being declared as "available" in the `Peripherals` struct while they are used...