ivmarkov

Results 697 comments of ivmarkov
trafficstars

I didn't say it is not properly implemented or not unit tested. It is just not so widely used. Would this indicate that the problem is not so major actually,...

I mean, if you want it, just use it *outside* of `embedded-svc` without introducing it as a dependency?

I'm moving towards simplicity and less convenience actually (e.g. see #16); and even some performance sacrifices. And little to no hard dependencies on external crates for the embedded-svc *core* (everything...

But yeah, I'll likely have to introduce a hard dependency on `heapless` in order to fix [this](https://github.com/esp-rs/embedded-svc/blob/master/src/wifi.rs#L161). Or introduce lifetimes.

Yeah. But then you need to do the same for the [ssid](https://github.com/esp-rs/embedded-svc/blob/master/src/wifi.rs#L143) field, so no - your type is not going to be named `Password`, but... `MyOwnNoAllocString`. Or something. And...

> > And then the question becomes, why are you reinventing the wheel? > > You are suggesting that having dependencies is a bad thing, so I assumed you wanted...

> Sure, it may have 1 star on GitHub, but it has 500k downloads on crates.io which I think is more indicative of its usage in the Rust ecosystem. That...

But then `Dependents` is a bit weak tho.

OK, let's see what the other folks on the esp-rs team have to say. I think we got too much into the weeds here discussing this detail (sorry for naming...

> While creating an embedded-svc wifi manager I came across some issues which could easily be resolved by expanding the http server traits (the new ones) or adding new traits...