invidious icon indicating copy to clipboard operation
invidious copied to clipboard

Published 20 hours ago • verified publisher icon iv-org

don't error when a channel doesn't have any community posts

Open ChunkyProgrammer opened this issue 1 year ago • 6 comments

we now return an empty array when there are no posts.

closes https://github.com/iv-org/invidious/issues/3814 https://github.com/FreeTubeApp/FreeTube/issues/3499

ChunkyProgrammer avatar Jan 30 '24 03:01 ChunkyProgrammer

I wanted to test this but I get "This channel hasn't posted yet" even if I don't have this pull request merged into my debug instance and that string doesn't even exists on the Invidious code.

image

image

image

However if I merge this pull request into my debug instance I don't even get the message "This channel hasn't posted yet" on Invidious. What is going on?

image

Fijxu avatar Feb 12 '24 20:02 Fijxu

That's the point. This PR makes Invidious response to blank responses from YouTube the same by displaying an empty page instead of an error message.

I'm not sure if I agree with not showing a message though. https://github.com/iv-org/invidious/issues/3814#issuecomment-1918129165

syeopite avatar Feb 12 '24 22:02 syeopite

I'm not sure if I agree with not showing a message though. #3814 (comment)

I can add a message to the invidious ui for the empty tabs (that way we can also include it in weblate). I don't think it would be that beneficial to include that message in the api imo

ChunkyProgrammer avatar Feb 12 '24 22:02 ChunkyProgrammer

I'm not sure if I agree with not showing a message though. #3814 (comment)

I can add a message to the invidious ui for the empty tabs (that way we can also include it in weblate). I don't think it would be that beneficial to include that message in the api imo

Yes please, that'd be great. This PR just comes with an unintentional side-effect of also removing the error message on the frontend side of things.

syeopite avatar Feb 14 '24 17:02 syeopite

When a community tab is empty it will display the message in the UI now :smile:

ChunkyProgrammer avatar Feb 16 '24 00:02 ChunkyProgrammer

build failure is unrelated to this PR and caused by changes in crystal nightly

ChunkyProgrammer avatar Mar 25 '24 15:03 ChunkyProgrammer

This pull request has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely abandoned or outdated. If you think this pull request is still relevant and applicable, you just have to post a comment and it will be unmarked.

github-actions[bot] avatar Jul 29 '24 01:07 github-actions[bot]

I think YouTube is hiding the community tab if it's empty now

ChunkyProgrammer avatar Jul 29 '24 01:07 ChunkyProgrammer