saml-auth-proxy icon indicating copy to clipboard operation
saml-auth-proxy copied to clipboard

Allowing literal commas in options

Open cspeterson-ias opened this issue 1 year ago • 2 comments

Hi! I'm the guy from this issue: https://github.com/itzg/go-flagsfiller/issues/31

If I had had noticed initially that you were the owner of both repos, I might have started here first. 🙂

saml-auth-proxy seems to do almost everything I need, except for allowing comma-bearing values to -authorize-values. Thanks so much for making this. And for being so responsive with the library!

I have zero experience with golang, but I'm willing to at least try to write the code to allow this. Would you be willing to accept such a change?

I could just hard-change main.go:23 to stop splitting commas like I did for my own build as a stop-gap, but that doesn't seem the right thing. What would you suggest?

Thanks!

cspeterson-ias avatar Dec 04 '23 16:12 cspeterson-ias

No problem about the sequence of repos. The context does help a lot though, since I'm now wondering if flagsfiller needs to allow for escaping commas (or delimiters in general). That way the usage would remain backward compatible. I'll give it some more thought...

itzg avatar Dec 04 '23 18:12 itzg

BTW, I have only partially forgotten about this issue 😄 Every now and then I'm giving this more thought because I'd instead like to have flagsfiller allow for escaping the configured/default delimiters since changing the delimiters now in saml-auth-proxy could break existing users.

itzg avatar Jan 01 '24 20:01 itzg