New logger with color and specific types. Code cleanup

[IronMine]

In this PR there is :

• Removing some unused functions
• A new logger system with colors
• A Warning specific logger ( yellow )
• An Eroor specific logger ( red )
• Fixing broken CanyonModded link url to jenkins
• Optimizing some curl calls
• A little bit of code cleanup
• Some proposal ( start-finalExec and start-setupServerProperties)

[itzg]

This is a lot of changes for one PR. I know this is hard after the fact, but is there any way you could break this up into a few smaller ones?

[IronMine]

will do !

[IronMine]

is there some things i listed that you do not want ?

[itzg]

Glancing at the changes I like all of it 😃

Actually, keep the PR as is and I'll review more closely when I get a span of time. With that I can raise any specific concerns I find, if any.

[IronMine]

Nice perfect ! As you want it is a huge PR i do understand if you would prefer it separate in multiple small ones

[itzg]

With new formatted logging, the output from DEBUG set to "true" is getting noisier, such as:

[init] 2024-10-20 16:46:51+00:00
+ logError '         SPONGEVANILLA, CUSTOM, MAGMA, MOHIST, CATSERVER, AIRPLANE, PUFFERFISH,'
++ getErrorColoredLogString '         SPONGEVANILLA, CUSTOM, MAGMA, MOHIST, CATSERVER, AIRPLANE, PUFFERFISH,'
++ echo '\033[0;31m[ERROR]          SPONGEVANILLA, CUSTOM, MAGMA, MOHIST, CATSERVER, AIRPLANE, PUFFERFISH, \033[0m'
+ log
+ local oldState
++ shopt -po xtrace
+ oldState='set -o xtrace'
+ shopt -u -o xtrace

It'll be redundant, but perhaps apply the same shopt-eval suppression of debug -x output around the logError and logWarn calls. All the more reason to keep the number of new logging functions minimal.

[itzg]

Ah, IntelliJ was actually reporting the problem:

[IronMine]

Thanks so much for working with me on all the feedback I provided.

your are welcome and i apologize for all the time you loose on my PR's ^^

[IronMine]

like that ?