docker-minecraft-server icon indicating copy to clipboard operation
docker-minecraft-server copied to clipboard

Option to allow use of outdated versions on modrinth

Open MattiDragon opened this issue 3 years ago • 5 comments

Enhancement Type

Improve an existing feature

Describe the enhancement

I would like to set up a fabric 1.19.2 (just released) server this image and download mods from modrinth, but most of my mods aren't getting downloaded as they haven't been marked for 1.19.2 support. Most have been marked for 1.19.1 support, but some are only marked for 1.18.2, but still work as the code they touch hasn't changed.

I would like to have a flag to make the image use a version of the mod for the latest mc version bellow the current one that the project supports. I don't really care if it's opt-in or opt-out as long as it's possible. Also, could you not just silently skip the mods?

I'm, using docker compose btw

MattiDragon avatar Aug 05 '22 15:08 MattiDragon

I think that's beyond my control. I'm using this API call

https://docs.modrinth.com/api-spec/#tag/versions/operation/getProjectVersions

and can only make use of what it responds. This seems like a request to post with Modrinth.

Out of curiosity, what mod is an example that is marked for 1.18.2 but works for 1.19.2?

itzg avatar Aug 05 '22 22:08 itzg

That api allows omitting the minecraft version, allowing you to do the checks yourself. For the 1.18 mod, it's https://modrinth.com/mod/zombify. Apparently it's 1.18.1, but still, it's so basic it probably still works

MattiDragon avatar Aug 06 '22 07:08 MattiDragon

That's an option in the API but how would the code determine if a mod file "probably still works"?

This sounds like a capability Modrinth should provide to mod publishers to designate a given mod file works with multiple Minecraft versions.

itzg avatar Aug 07 '22 17:08 itzg

Mod publishers can set multiple versions, but some forget. My suggestion was to make this image pull the latest (older) version if a matching one isn't found. It would be up to the user to find valid mods. Another option would be the ability to specify version ids to download, but then we wouldn't have auto updates

MattiDragon avatar Aug 08 '22 05:08 MattiDragon

Another option would be the ability to specify version ids to download, but then we wouldn't have auto updates

This can be done. Software can do deterministic things like this leaving a human to make the fuzzy decision.

itzg avatar Aug 08 '22 13:08 itzg

This issue is stale because it has been open 30 days with no activity. Please add a comment describing the reason to keep this issue open.

github-actions[bot] avatar Sep 08 '22 02:09 github-actions[bot]

I need a new stalebot...this is queued up in https://github.com/users/itzg/projects/4/views/1

itzg avatar Oct 18 '22 17:10 itzg

This issue is stale because it has been open 30 days with no activity. Please add a comment describing the reason to keep this issue open.

github-actions[bot] avatar Nov 18 '22 02:11 github-actions[bot]