docker-bungeecord icon indicating copy to clipboard operation
docker-bungeecord copied to clipboard

Downloads from Spiget include incompatible jars

Open alvarlagerlof opened this issue 4 years ago • 10 comments

https://www.spigotmc.org/resources/bungeetablistplus.313/

I using this results in errors because it includes jar files for sponge and more which are attempted to run. Is there way to fix this?

alvarlagerlof avatar Oct 21 '21 14:10 alvarlagerlof

I'm not sure how to help with this. If Spiget provided incorrect content, then report the issue with them. If the plugin content from Spigot is wrong then contact the plugin author.

You can add -e DEBUG=true if you need to see and report the exact spiget operations that were used.

itzg avatar Oct 21 '21 18:10 itzg

I'm not sure the author is going to stop shipping a zip file if they have multiple versions though? I was thinking maybe of a block list?

alvarlagerlof avatar Oct 21 '21 22:10 alvarlagerlof

I'm sorry, now I'm even more confused. Can you provide the compose file or docker run command you're using? Maybe seeing what you're trying will help me.

itzg avatar Oct 21 '21 23:10 itzg

Sure! Id 313 is what downloads a zip with a bunch of incompatible jars.

/bin/podman run
-it
-v /mnt/ssd/minecraft/%N/config:/config:ro
-v /mnt/ssd/minecraft/%N/plugins:/plugins:ro
-v /mnt/ssd/minecraft/%N/server:/server
--security-opt label=disable
--network minecraft
-p 25565:25577
-e SPIGET_PLUGINS=73064,313
-e TYPE=WATERFALL
-e ENABLE_RCON=true
-e MEMORY=256m
docker.io/itzg/bungeecord:latest

I use podman but the API is the same.

alvarlagerlof avatar Oct 22 '21 10:10 alvarlagerlof

Thanks for providing that. I'm not sure what I can do to fix this since my scripts just call the spiget API and have no control over the response from them.

itzg avatar Oct 22 '21 12:10 itzg

Yeah I'm realizing that now too. The Spiget API doesn't seem to have any concept of "sub-resources" or the likes at all. And the plugin author says that they bundle them for convenience. There should be a real package manager for these plugins, imo.

The block list I was talking about was possibly to have the script rm files from a list, but the file names are not stable either, so that is of no use.

alvarlagerlof avatar Oct 22 '21 14:10 alvarlagerlof

I would be able to improve my situation somewhat if PLUGINS also took zip urls as arguments.

alvarlagerlof avatar Oct 22 '21 15:10 alvarlagerlof

I would be able to improve my situation somewhat if PLUGINS also took zip urls as arguments.

That's an interesting idea. And for zips it would simply unzip the contents into the plugins directory?

itzg avatar Oct 22 '21 16:10 itzg

That's an interesting idea. And for zips it would simply unzip the contents into the plugins directory?

Yes, exactly. I believe it already does this for Spiget resources that are zips? https://github.com/itzg/docker-bungeecord/blob/ea211a6bbd499398bd1f3b377c99d01b86d16227/run-bungeecord.sh#L81

alvarlagerlof avatar Oct 22 '21 22:10 alvarlagerlof

This issue is stale because it has been open 30 days with no activity. Please add a comment describing the reason to keep this issue open.

github-actions[bot] avatar Nov 22 '21 00:11 github-actions[bot]