Geoff Bourne

Results 719 comments of Geoff Bourne

> I had not yet fully considered the how to avoid redundant .mrpack downloads. I did notice the Modrinth API based fetch flow avoiding redundant downloads based on pack version...

I will need to investigate further, but it is most likely a deficiency in the particular mod pack declarations. Image helper will traverse the dependencies by specific version unless, but...

mc-image-helper seems to be following the dependencies correctly as declared by the mod metadata. The first one to pull YetAnotherConfigLib is https://modrinth.com/mod/debugify/version/2.8.0 which says it requires https://modrinth.com/mod/yacl/version/2.0.0. That one says...

BTW debug output is how I initially found the bad metadata: (Trimmed and extracted the first occurrence of YetAnotherConfigLib and dependency reference to it.) ``` [mc-image-helper] 18:22:21.267 DEBUG : Expanding...

Can you please provide some examples?

To clarify, please provide files that recreate the problem. I cannot work on this until that is provided.

I'm sorry, I was obviously in a "bug report" mode there. Actually, some example files (lang file, patch set file(s), etc) would still help even if they're made up files...

...and read your follow up comment one more time and I think it's clicking for me. It's kind of like a "diff" operation where given the two JSON files, identify...

No, thanks, I think I know where to go with this now. Just to clarify does it seem reasonable to one-off run mc-image-helper with a new subcommand like "patch-create"?

That's a great suggestion. I'll get that queued up.