to-google-translate icon indicating copy to clipboard operation
to-google-translate copied to clipboard

New Ctrl + Shift + B shortcut is conflicting with other shortcuts

Open PuttTim opened this issue 6 years ago • 6 comments

Ctrl + Shift + B to translate a text is conflicting with Firefox's "Library window (Bookmarks)" and so it currently doesn't translate any text if you use it.

My suggestion would be to do Ctrl + Shift + Y/F/Q/Z as these are easy to reach, or if you really don't want anything to conflict with it.. do Ctrl + Shift + (number) as there's nothing in Firefox currently using these exact combinations of keys for a shortcut

PuttTim avatar Nov 07 '19 15:11 PuttTim

Thank you for reporting this with the proper solution. I think the fix will be available tomorrow.

itsecurityco avatar Nov 07 '19 15:11 itsecurityco

The shortcut has change to 1,2,3 because Ctrl + Shift + Y in Linux Firefox opens Library... so looks like it changes depends on OS.

itsecurityco avatar Nov 07 '19 18:11 itsecurityco

Reza Karami said: There must be a way to disable keyboard shortcuts or change it Ctrl + shift + 2 is the "Zero-width non-joiner" character and I can't use it anymore!

Source: https://addons.mozilla.org/en-US/firefox/addon/to-google-translate/reviews/1445150/

itsecurityco avatar Nov 12 '19 01:11 itsecurityco

Some update about this? i have problem with conflict ctrl + shift + 1 .. i used it for quick switch to the first tab. i would prefer for disabling shortcut because i am using plugin by context menu

lukyrys avatar Nov 27 '19 11:11 lukyrys

Firefox has documentation on how to manage extension shortcuts at https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/commands

A normal user can do this, without extension support. Quoting from the link above:

Updating shortcuts

Shortcuts can be updated via commands.update(). Users can also update shortcuts via the "Manage Extension Shortcuts" option at about:addons in Firefox, as shown in this video. In Chrome, users can change shortcuts at chrome://extensions/shortcuts.

This Firefox configuration option is exposed as a setting ("cog wheel" icon in the right upper corner), with context menu entry.

This implies that extensions do not need to implement anything to have configurable keyboard shortcuts (or have them removed).

@itsecurityco - perhaps you might want to add some note about keyboard shortcut configuration in your readme?

FWIW, I had a keyboard shortcut conflict with the browser zoom shortcut. That made me investigate.

shoffmeister avatar Mar 15 '20 07:03 shoffmeister

Hello, just installed the extension and straight away, its default shortcuts are interfering with default focus tab keyboard shortcuts in the Firefox browser. Pressing Ctrl+Shift+1 switches to the first tab but also opens the translate popup (which is empty as there's previously selected text in the fab, of course). Thanks @shoffmeister for the workaround.

sKopheK avatar Apr 01 '20 05:04 sKopheK