itext-java
itext-java copied to clipboard
timezone is not supported in digital signs
when the certificate is added, there is an option to add signed by, reason, location and the signed date. timezone is not supported currently in the signed date. this change is to fix that.
Hi @klpitshah, thank you for your Pull Request! Could you sign the CLA (https://github.com/itext/itext7/blob/develop/CONTRIBUTING.md#cla) and send to us? We also kindly ask you to add a test to your fix/improvement - this will speed up the process of the PR review.
Hi Alexey, PFA the signed CLA.
Kalpit Shah
On Mon, Apr 18, 2022 at 4:43 PM Alexey Subach @.***> wrote:
Hi @klpitshah https://github.com/klpitshah, thank you for your Pull Request! Could you sign the CLA ( https://github.com/itext/itext7/blob/develop/CONTRIBUTING.md#cla) and send to us? We also kindly ask you to add a test to your fix/improvement - this will speed up the process of the PR review.
— Reply to this email directly, view it on GitHub https://github.com/itext/itext7/pull/90#issuecomment-1101320594, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJO46CETVXMYEBPKZ7N5O23VFU7WLANCNFSM5TVQSGLA . You are receiving this because you were mentioned.Message ID: @.***>
Hey @klpitshah, I'm afraid the file didn't come through (don't see it in the GitHub or email)
ISG Contributor License Agreement 2021.pdf added here @Snipx
Hey @klpitshah, thank you for attaching the document. We'd need a printed-signed-scanned document or a proper digital signature though (as described at https://itextpdf.com/en/how-buy/legal/itext-contributor-license-agreement). Would you be able to do either of those? Right now you added some stamps on the original document bit it's not a digital signature. Thanks
Hi, Can you check now, please? Kalpit Shah
On Mon, Apr 18, 2022 at 7:25 PM Alexey Subach @.***> wrote:
Hey @klpitshah https://github.com/klpitshah, I'm afraid the file didn't come through (don't see it in the GitHub or email)
— Reply to this email directly, view it on GitHub https://github.com/itext/itext7/pull/90#issuecomment-1101426859, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJO46CBVY4SS4ENOBJQ3HTLVFVSUHANCNFSM5TVQSGLA . You are receiving this because you were mentioned.Message ID: @.***>
Hi @klpitshah ,
Unfortunately I don't see the new signed file anywhere you sent us on October 11th. Could you let me know where to find it or re-send me the file so we can proceed on this PR?
Kind regards, Michaël.