dvc icon indicating copy to clipboard operation
dvc copied to clipboard

import/get: escape non-pattern LFS path parts

Open sisp opened this issue 1 year ago • 2 comments

  • [x] ❗ I have followed the Contributing to DVC checklist.

  • [ ] ~~📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.~~

I've fixed a bug related to passing literal/non-pattern path (parts) to the LFS prefetching function from scmrepo which would interpret them as Unix filename patterns and result in incorrect path filtering results. Now, the literal/non-path path (parts) are escaped.

See https://github.com/iterative/scmrepo/pull/355#discussion_r1589847222 for the preceding discussion.

/cc @shcheklein

sisp avatar May 07 '24 08:05 sisp

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.50%. Comparing base (a7c0f6e) to head (59ea6c6). Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10416   +/-   ##
=======================================
  Coverage   90.50%   90.50%           
=======================================
  Files         502      503    +1     
  Lines       38982    39004   +22     
  Branches     5622     5626    +4     
=======================================
+ Hits        35279    35300   +21     
- Misses       3006     3007    +1     
  Partials      697      697           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 07 '24 08:05 codecov[bot]

@shcheklein Done. WDYT?

sisp avatar May 11 '24 14:05 sisp

Thanks for your feedback, @shcheklein! Would you mind another review? :pray:

sisp avatar May 12 '24 19:05 sisp

thanks @sisp !

shcheklein avatar May 13 '24 17:05 shcheklein