dvc icon indicating copy to clipboard operation
dvc copied to clipboard

In monorepo: Incorrect link to Studio view

Open mnrozhkov opened this issue 1 year ago • 5 comments

Bug Report

I'm testing DVC Experiments for monorepo scenario using this repo. I encountered unexpected behavior for dvc exp push

Within a mono repo say we have:

- / 
  - project_a
  - project_b
  - root_content

In Studio, I created a project for project_a subdir. When working inside project_a, I run dvc exp push, but the generated link is not correct!

➜  ~/dev/test/monorepo-multiproject-detached-exps/project_a|main⚡ ⇒  dvc exp push origin -A
Collecting                                                                                                                                                 |0.00 [00:00,    ?entry/s]
Pushing
Experiment pucka-navy and pucka-navy are up to date on Git remote 'origin'.
Pushed experiment fated-zips, fated-zips, bluer-furl and bluer-furl to Git remote 'origin'.
View your experiments at https://studio.iterative.ai/team/cse-test/projects/monorepo-multiproject-detached-exps-kul2k64s01

mnrozhkov avatar Jan 18 '24 10:01 mnrozhkov

Thanks @mnrozhkov! As mentioned in Notion, I'm not sure how DVC can handle this (we would probably need to change the Studio API), but let's keep it open so we have a record and can come back to it.

dberenbaum avatar Jan 18 '24 12:01 dberenbaum

Also, I notice you have duplicate experiment names being shown (like pucka-navy and pucka-navy). Do you know how you got that?

dberenbaum avatar Jan 18 '24 12:01 dberenbaum

dvc exp push origin -A

It's interesting, I didn't notice that. I guess it's because of the same reason - some operations have a scope of DVC project dir, but other not.

  • to run dvc exp list I need to be inside project_a or project_b (I can't run it in the repo root)

  • but after I run dvc exp run, both projects show the same experiment list

  • with command dvc exp push origin only a single experiment push mentioned in the log image

  • with command dvc exp push origin -A I can reproduce this behavior

image

mnrozhkov avatar Jan 18 '24 19:01 mnrozhkov

@mnrozhkov can you run this command in that git repo and post the output (it shouldn't matter which dvc subrepo you are in)

git show-ref pucka-navy

pmrowla avatar Jan 19 '24 01:01 pmrowla

@pmrowla I removed the previous experiment. Below is the similar behavior with ninth-whin exp

➜  ~/dev/test/monorepo-multiproject-detached-exps/project_a|main⚡ ⇒  dvc exp push origin -A        
Collecting                                                                                                                                                         |0.00 [00:00,    ?entry/s]
Pushing
Experiment ninth-whin and ninth-whin are up to date on Git remote 'origin'.
View your experiments at https://studio.iterative.ai/team/cse-test/projects/monorepo-multiproject-detached-exps-kul2k64s01
                                                                                                                                                                                             
➜  ~/dev/test/monorepo-multiproject-detached-exps/project_a|main⚡ ⇒  git show-ref ninth-whin
267911cc33f7756bf0738c1e87de98cc18a35762 refs/exps/9e/a7df3681418ad28003aa792c1aef3025f61265/ninth-whin

mnrozhkov avatar Jan 19 '24 12:01 mnrozhkov