solid-command-palette icon indicating copy to clipboard operation
solid-command-palette copied to clipboard

Version of peer-dependencies should be specified

Open on3iro opened this issue 2 years ago • 3 comments

Hey folks,

again, following the example from the README I ran into an issue, where a newer version of tinykey does no longer have a default export. If I am not mistaken the hint to install peer dependencies should be unnecessary, as they should be installed automatically. However if you want users to install them manually, the correct version should be specified inside the README :)

I am also receiving an error with tinykeys:

TypeError: t2.trim is not a function. (In 't2.trim()', 't2.trim' is undefined)

In general it would probably make sense to update dependencies - if you want me to, I could create a PR.

on3iro avatar Jun 25 '23 07:06 on3iro

PR would be appreciated. Thanks @on3iro

itaditya avatar Jun 28 '23 14:06 itaditya

I'm also hitting t2.trim is not a function error. I can't trace exactly where it is yet because the stackblitz demo works. Weirdly could be possibly due to solid-js latest version.

lominming avatar Oct 14 '23 05:10 lominming

Just did a PR for this.

Canna71 avatar Jul 28 '24 15:07 Canna71