background-check icon indicating copy to clipboard operation
background-check copied to clipboard

add method parameter validations in github-apis

Open itaditya opened this issue 7 years ago • 2 comments

The functions don't check if the passed parameter even exist or not. This can cause issues while usage.

itaditya avatar Jul 04 '18 12:07 itaditya

The Octokit methods (and the Octokit library) all have validation to make sure that the required parameters are passed. This was introduced in a fairly recent version, not sure which, so you might want to upgrade and see if that helps.

JasonEtco avatar Jul 04 '18 16:07 JasonEtco

Oh thanks for pointing this out !!

itaditya avatar Jul 04 '18 18:07 itaditya