stuff
stuff copied to clipboard
deadbeef-archreader compile failure fix+other issues
trafficstars
Various concerns:
- It has a compile failure:
error: invalid conversion from ‘int’ to ‘blargg_err_t’ {aka ‘const char*’} [-fpermissive]This issue can be resolved with the blargg patch from the abandoned deadbeef-overlay. The other patch isn't needed to compile and I'm not sure of what value it does or doesn't bring. - Why is it named
deadbeef-archreaderoverdeadbeef-archive-reader? archreader is less descriptive, it's never referenced as such on its site, and you use the full name for other plugins in this repository - The description misspells DeaDBeeF and is otherwise awkwardly worded. I'd go with something like:
DeaDBeeF archive reader plugin that enables playing files directly from RAR, 7z and Gzip archive files - You have the wrong license. It's licensed under
LGPL-2.1
Thanks for pointing it out will look into it ASAP!
Many thanks, we applied corrections. Could you please check it again?