istio.io icon indicating copy to clipboard operation
istio.io copied to clipboard

Added social share button in Blog page.

Open shivamgupta2020 opened this issue 1 year ago • 8 comments
trafficstars

Description

Added social share button for faster sharing of blog post on social sites. Try to fix #14504 .

Reviewers

  • [ ] Ambient
  • [ ] Docs
  • [ ] Installation
  • [ ] Networking
  • [ ] Performance and Scalability
  • [ ] Extensions and Telemetry
  • [ ] Security
  • [ ] Test and Release
  • [X] User Experience
  • [ ] Developer Infrastructure
  • [ ] Localization/Translation

shivamgupta2020 avatar Jan 29 '24 20:01 shivamgupta2020

😊 Welcome! This is either your first contribution to the Istio documentation repo, or it's been a while since you've been here. A few things you should know:

  • You can learn about how we write and maintain documentation, our style guidelines, and the available web site features by visiting Contributing to the Docs.

  • In the next few minutes, an automatic preview of your change will be built with a full copy of the istio.io website. You can find this preview by clicking on the Details link next to the deploy/netlify entry in the status section of this page.

  • We care about quality, so we've put in place a number of checks to ensure our documentation is top-notch. We do spell checking, sanitize the Markdown, ensure all hyperlinks point to a valid location, and more. If your PR doesn't pass one of these checks, you'll see a red X in the lint_istio.io entry in the status section. Click on the Details link to get a list of the problems with your PR. Fix those problems and push an update; this will automatically re-run the tests. Hopefully this time everything will be perfect!

  • Once your changes are accepted and merged into the repository, they will initially show up on https://preliminary.istio.io. The changes will be published to https://istio.io the next time we do a major release (which typically happens every 3 months or so). To publish them sooner, add a cherrypick/release-x.xx label, where x.xx is the current release of Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

istio-policy-bot avatar Jan 29 '24 20:01 istio-policy-bot

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: shivamgupta2020 / name: Shivam Gupta (948ed242ba96a7e608d34f4d70db7b5f696167b4, 6fe76338e31f08b76a8f5820a76dc21ddf6bfa6a, 248d3aadd15a955f33463316926c60549839e5a1, bfcca105d8bb123445cf435dd4f7c65bd6e38d80, 60ab6469c337e350b9b95ae5d84722a7b5586bb5, 202175597326c29d3688c6d21e5245083a113f31, 686d7cf2b9e85aeccf246e0eacdac15025697942, af28a66a06ea6fa373dc635ccf1c4f1ce76bd944, 7964f3381a289cf0fc8098b26f1bd467c43d42ca, d6cf3269bd378c9eb84376dff1f7506ddc031152, a0a08aca47bcd151c909a32afad8137ccffb19b4, eced90f69296959253b22d708de87c8021090711, a3f593c533b2c049e2a69dc53c394e1e7da19b10)

Hi @shivamgupta2020. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

istio-testing avatar Jan 29 '24 20:01 istio-testing

/ok-to-test

kfaseela avatar Jan 29 '24 20:01 kfaseela

Please sign the CLA

kfaseela avatar Jan 29 '24 20:01 kfaseela

@dhawton I am confused on how the img are rendering in this site. I tried to use relative path but images doesn't load. On seeing other files I realized maybe "{{ partial "icon.html" "name" }}" may work, but I dont understand how exactly it will work. Can u suggest me where I can look or what I can do?

shivamgupta2020 avatar Jan 29 '24 21:01 shivamgupta2020

@dhawton I am confused on how the img are rendering in this site. I tried to use relative path but images doesn't load. On seeing other files I realized maybe "{{ partial "icon.html" "name" }}" may work, but I dont understand how exactly it will work. Can u suggest me where I can look or what I can do?

You can place in /static/img and then from the image tag, src="/img/...", for example. I'd personally create a /static/img/social/(site).svg and with img src="/img/social/(site).svg"

dhawton avatar Jan 29 '24 21:01 dhawton

@dhawton I have made changes regarding images and formatting. Please review. Also, as the share link is based on customized URL so it aint working in preview. But I tested it with the URL of website, so I guess it will work on real deployed website.

shivamgupta2020 avatar Jan 31 '24 13:01 shivamgupta2020