istio.io icon indicating copy to clipboard operation
istio.io copied to clipboard

[zh]Sync File Location

Open justedennnnn opened this issue 3 years ago • 3 comments
trafficstars

Please provide a description for what this PR is for.

And to help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • [ ] Configuration Infrastructure
  • [X] Docs
  • [ ] Installation
  • [ ] Networking
  • [ ] Performance and Scalability
  • [ ] Policies and Telemetry
  • [ ] Security
  • [ ] Test and Release
  • [ ] User Experience
  • [ ] Developer Infrastructure

justedennnnn avatar Sep 22 '22 02:09 justedennnnn

😊 Welcome! This is either your first contribution to the Istio documentation repo, or it's been awhile since you've been here. A few things you should know:

  • You can learn about how we write and maintain documentation, about our style guidelines, and about all the available web site features by visiting Contributing to the Docs.

  • In the next few minutes, an automatic preview of your change will be built as a full copy of the istio.io website. You can find this preview by clicking on the Details link next to the deploy/netlify entry in the Status section of this page.

  • We care about quality, so we've put in place a number of checks to ensure our documentation is top notch. We do spell checking, we sanitize the markdown, we ensure all hyperlinks point to valid location, and more. If your PR doesn't pass one of these checks, you'll see a red X in the status section of the page. Click on the Details link to get a list of the problems with your PR. Fix those problems and push an update to your PR. This will automatically rerun the tests and hopefully this time everything will be perfect.

  • Once your changes are accepted and merged into the repository, they will initially show up on https://preliminary.istio.io. The changes will be published to https://istio.io the next time we do a major release (which typically happens every 3 months or so).

Thanks for contributing!

Courtesy of your friendly welcome wagon.

istio-policy-bot avatar Sep 22 '22 02:09 istio-policy-bot

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Sep 22 '22 02:09 google-cla[bot]

Hi @justedennnnn. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

istio-testing avatar Sep 22 '22 02:09 istio-testing

/ok-to-test

windsonsea avatar Sep 22 '22 08:09 windsonsea

*.sh should be removed

got it.

justedennnnn avatar Sep 22 '22 09:09 justedennnnn

@zirain @justedennnnn so this change is to remove additional-setup directory entirely and move the two svg files to external-controlplane directory? If so, seems to me that the only files in this new external-controlplane directory will be the two svg files, how will that actually work? is there a dependent PR still open somewhere?

litong01 avatar Sep 22 '22 11:09 litong01

it's broken before this.

before: image

after: image

zirain avatar Sep 22 '22 11:09 zirain

BTW, would you please check the content, it should synced to EN @justedennnnn

zirain avatar Sep 22 '22 11:09 zirain

BTW, would you please check the content, it should synced to EN @justedennnnn

Do you mean to remove the English version of these two .sh files?

justedennnnn avatar Sep 22 '22 12:09 justedennnnn

BTW, would you please check the content, it should synced to EN @justedennnnn

Do you mean to remove the English version of these two .sh files?

中文文档内容可能已经与英文不同步,请一并检查确认下

zirain avatar Sep 23 '22 01:09 zirain

BTW, would you please check the content, it should synced to EN @justedennnnn

Do you mean to remove the English version of these two .sh files?

中文文档内容可能已经与英文不同步,请一并检查确认下

已更新

justedennnnn avatar Sep 24 '22 04:09 justedennnnn

/test lint

justedennnnn avatar Sep 24 '22 14:09 justedennnnn

please fix CI

zirain avatar Sep 25 '22 08:09 zirain

with your latest change, the page is broken again!

image

zirain avatar Sep 28 '22 01:09 zirain

Hi @justedennnnn, would you like to move this forward after a month passed?

If no any response in weeks, this will be closed. Thanks for your understanding.

windsonsea avatar Nov 03 '22 13:11 windsonsea

Hi @justedennnnn, would you like to move this forward after a month passed?

If no any response in weeks, this will be closed. Thanks for your understanding.

@windsonsea if someone is also interesting in this, I'm ok to merge this first, then send a following PR to fix the rest, WDYT?

zirain avatar Nov 10 '22 02:11 zirain

ok, all right.

windsonsea avatar Nov 10 '22 02:11 windsonsea

remove cherry-pick

zirain avatar Nov 10 '22 03:11 zirain