admiral icon indicating copy to clipboard operation
admiral copied to clipboard

MESH-5405-Create prefixed SEs

Open Punakshi opened this issue 1 year ago • 2 comments
trafficstars

Checklist

🚨 Please review this repository's contribution guidelines.

  • [ ] I've read and agree to the project's contribution guidelines.
  • [ ] I'm requesting to pull a topic/feature/bugfix branch.
  • [ ] I checked that my code additions will pass code linting checks and unit tests.
  • [ ] I updated unit and integration tests (if applicable).
  • [ ] I'm ready to notify the team of this contribution.

Description

What does this change do and why? Handles the canary, bluegreen, deployment to rollout migration

[Link to related ISSUE]

Thank you!

Punakshi avatar Sep 05 '24 17:09 Punakshi

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 37.25490% with 128 lines in your changes missing coverage. Please review.

Project coverage is 71.02%. Comparing base (61e7c3f) to head (e553489).

Files with missing lines Patch % Lines
admiral/pkg/registry/testutils.go 9.09% 100 Missing :warning:
admiral/pkg/clusters/serviceentry.go 15.00% 17 Missing :warning:
admiral/pkg/clusters/configwriter.go 85.50% 5 Missing and 5 partials :warning:
admiral/pkg/clusters/util.go 50.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #336      +/-   ##
==========================================
- Coverage   71.83%   71.02%   -0.81%     
==========================================
  Files          66       66              
  Lines        9269     9394     +125     
==========================================
+ Hits         6658     6672      +14     
- Misses       2251     2359     +108     
- Partials      360      363       +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 05 '24 17:09 codecov-commenter

Looks good - only thing is that need some comments to explain the service map structure and expectations of state syncer. Meaning, we should only have default and test keys, should only have one service in the array value for the test key, etc. (in getServiceEntryEndpoints)

rtay1188 avatar Sep 12 '24 18:09 rtay1188