Open3D
Open3D copied to clipboard
only compile ExtractZIP when WITH_MINIZIP is enabled
Fix compilation with WITH_MINIZIP set to OFF.
Type
- [x] Bug fix (non-breaking change which fixes an issue): Fixes #
- [ ] New feature (non-breaking change which adds functionality). Resolves #
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #
Motivation and Context
Fix compiling ExtractZIP.cpp when WITH_MINIZIP is OFF. See https://github.com/isl-org/Open3D/pull/7177#issuecomment-2911193232.
Checklist:
- [x] I have run
python util/check_style.py --applyto apply Open3D code style to my code. - [ ] This PR changes Open3D behavior or adds new functionality.
- [ ] Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is updated accordingly.
- [ ] I have added or updated C++ and / or Python unit tests OR included test results (e.g. screenshots or numbers) here.
- [x] I will follow up and update the code if CI fails.
- [x] For fork PRs, I have selected Allow edits from maintainers.
Description
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.
@ssheorey Many tests fail because the log file /root/open3d_data/extract/SampleRedwoodRGBDImages/trajectory.log cannot be read. I guess this log file is compressed and cannot be read because of the missing ExtractZIP.cpp support. Should the test be disabled in this case?
Hi @christian-rauch I'd prefer to just keep minizip ON all the time, to simplify the config and build process. We can just remove that option and fail the build if minizip is not available.
@ssheorey Can you check this again? WITH_MINIZIP is now ON again.