Open3D icon indicating copy to clipboard operation
Open3D copied to clipboard

feat: upgrade curl latest version

Open dinnercoding opened this issue 1 year ago • 6 comments

Type

  • [x] Bug fix (non-breaking change which fixes an issue): Fixes #6900
  • [ ] New feature (non-breaking change which adds functionality). Resolves #
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

The release files are using older version(7.88.0), but this softwares have many vulnerabilities. So I upgrade version to 8.10.1 image

Checklist:

  • [x] I have run python util/check_style.py --apply to apply Open3D code style to my code.
  • [ ] This PR changes Open3D behavior or adds new functionality.
    • [ ] Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is updated accordingly.
    • [ ] I have added or updated C++ and / or Python unit tests OR included test results (e.g. screenshots or numbers) here.
  • [x] I will follow up and update the code if CI fails.
  • [x] For fork PRs, I have selected Allow edits from maintainers.

Description

Hello this is my first time opening a pull request in Open3D. I'm not sure the right file is generated. Below is my command. Thank you.

docker run -it -v .:/app ubuntu:18.04
VERSION=8.10.1

apt-get update -y
apt-get install -y nghttp2 libnghttp2-dev libssl-dev build-essential wget
apt-get install libpsl-dev
wget https://curl.haxx.se/download/curl-${VERSION}.tar.gz
tar -xzvf curl-${VERSION}.tar.gz 
rm -f curl-${VERSION}.tar.gz
cd curl-${VERSION}
./configure --prefix=/usr/local --with-ssl --with-nghttp2
make -j4
make install
tar -cvf curl_8.10.1_linux_x86_64.tar.bz2 include lib

File curl_8.10.1_linux_x86_64.tar.zip

reference

dinnercoding avatar Oct 22 '24 14:10 dinnercoding

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

update-docs[bot] avatar Oct 22 '24 14:10 update-docs[bot]

Hi @Kim-jy0819 thanks for submitting this PR. I fixed some undefined symbol errors on macOS. Also, we will no longer host curl binaries to make it easier to do version updates in the future.

Looks good - tested locally. We can merge once CI passes.

ssheorey avatar Nov 17 '24 08:11 ssheorey

Hi @ssheorey,

Thank you for the review and approval! I really appreciate your work on resolving the undefined symbol errors on macOS and the advice on not hosting curl binaries.

Regarding the CI failures (e.g., on MacOS and Ubuntu), I’m currently looking into the logs, but I’m finding it challenging to pinpoint the exact cause. If you have any insights or suggestions on where I should focus my attention, that would be incredibly helpful.

I’ll continue investigating in the meantime and will keep you updated on my progress. Thank you again for your support!

dinnercoding avatar Nov 17 '24 15:11 dinnercoding

how is it going? @dinnercoding

johnnynunez avatar Apr 26 '25 11:04 johnnynunez

Thank you for reminding me. @johnnynunez Can you review again? @ssheorey

dinnercoding avatar Apr 27 '25 14:04 dinnercoding

can you merge this? @ssheorey

johnnynunez avatar May 06 '25 12:05 johnnynunez