Open3D icon indicating copy to clipboard operation
Open3D copied to clipboard

Enable Embree build with SYCL support and OneAPI 2024.1.0

Open lumurillo opened this issue 1 year ago • 2 comments

Enable the SYCL support for the Embree package.

Type

  • [ ] Bug fix (non-breaking change which fixes an issue): Fixes #
  • [x] New feature (non-breaking change which adds functionality). Resolves #
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

This change will allow the implementation of SYCL GPU implementation for the RayCastingScene class.

Checklist:

  • [x] I have run python util/check_style.py --apply to apply Open3D code style to my code.
  • [x] This PR changes Open3D behavior or adds new functionality.
    • [ ] Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is updated accordingly.
    • [ ] I have added or updated C++ and / or Python unit tests OR included test results (e.g. screenshots or numbers) here.
  • [x] I will follow up and update the code if CI fails.
  • [x] For fork PRs, I have selected Allow edits from maintainers.

Description

  • Updated the OneAPI version for the Docker files.
  • Updated the CMake version.
  • Disable the build of the ISPC module.

lumurillo avatar May 31 '24 21:05 lumurillo

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

update-docs[bot] avatar May 31 '24 21:05 update-docs[bot]

Hi @lumurillo can you update the embree Python examples to use SYCL devices, if available?

examples/python/geometry/ray_casting_closest_geometry.py
examples/python/geometry/ray_casting_sdf.py
examples/python/geometry/ray_casting_to_image.py

ssheorey avatar Jun 03 '24 23:06 ssheorey

Some updates needed to pass the CUDA CI tests. I made a branch copy and ran them here: https://github.com/isl-org/Open3D/actions/runs/11887514382

@lumurillo I'll take care of this.

ssheorey avatar Nov 18 '24 15:11 ssheorey

Looks good. We can visit the wait_and_throw() optimization later. Thanks @lumurillo !

ssheorey avatar Nov 19 '24 06:11 ssheorey