Open3D icon indicating copy to clipboard operation
Open3D copied to clipboard

Published 20 hours ago • verified publisher icon isl-org

Update to latest GLFW

Open errissa opened this issue 1 year ago • 16 comments

Type

  • [ ] Bug fix (non-breaking change which fixes an issue): Fixes #
  • [x] New feature (non-breaking change which adds functionality). Resolves #
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

Updates Open3D to use the latest GLFW as the version we had been using is several years old and predates Mac API changes. Also, updated to build system to build GLFW as external project to make it consistent with the rest of Open3D's use of third party libraries.

Checklist:

  • [X] I have run python util/check_style.py --apply to apply Open3D code style to my code.
  • [ ] This PR changes Open3D behavior or adds new functionality.
    • [ ] Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is updated accordingly.
    • [ ] I have added or updated C++ and / or Python unit tests OR included test results (e.g. screenshots or numbers) here.
  • [ ] I will follow up and update the code if CI fails.
  • [ ] For fork PRs, I have selected Allow edits from maintainers.

Description

errissa avatar Jan 09 '24 23:01 errissa

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

update-docs[bot] avatar Jan 09 '24 23:01 update-docs[bot]

Looks good. We can merge after testing. Thanks!

ssheorey avatar Jan 11 '24 06:01 ssheorey

Possibly fixes #1673

ssheorey avatar Jan 30 '24 04:01 ssheorey

Test draw example and O3DVisualizer. Also test legacy visualizer.

ssheorey avatar Jan 30 '24 16:01 ssheorey

Hi @errissa can you check the error in the documentation CI? Also, do all examples run for you? I got a crash in one draw.py example on Intel macOS.

ssheorey avatar Feb 09 '24 23:02 ssheorey

Works for me on intel Mac now.

ssheorey avatar Feb 27 '24 21:02 ssheorey

Everything works, except double clicking on a file in macOS does not open the file with Open3D. Need to check how macOS is passing the file name to glfw.

ssheorey avatar Mar 05 '24 15:03 ssheorey

Hi @errissa let's go ahead and merge this PR and the filament update PR as is. We'll open an issue for the "double clicking on file doesn't open in Open3D viewer" and fix it later.

ssheorey avatar Jul 09 '24 17:07 ssheorey

FIXME: Intel macOS: No window when opening app without a file (e.g. double click).

ssheorey avatar Aug 15 '24 17:08 ssheorey