Open3D icon indicating copy to clipboard operation
Open3D copied to clipboard

Enable shared library linking for open3d*.wheel

Open yuecideng opened this issue 2 years ago • 2 comments

Type

  • [ ] Bug fix (non-breaking change which fixes an issue): Fixes #
  • [ ] New feature (non-breaking change which adds functionality). Resolves #
  • [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

This PR aims at solving the issue mentioned at #5904.

steps:

cd Open3D
mkdir build && cd build
cmake .. -DBUILD_SHARED_LIBS=ON
make 
make install-pip-package

The c++ lib and include will be installed inside the open3d package , which is in the current python environment. The open3d/cpu/pybind*.so (eg. ubuntu, cpu version) will is linked with the open3d/lib/libOpen3D.so

I have tested the change on macos and ubuntu 20.04. Windows is not yet tested. I will follow up if the CI fail.

TODO:

  • [ ] Add changes to CI, such that the wheels are built with -DBUILD_SHARD_LIBS=ON.
  • [ ] Add variable to open3d to indicate the path of cmake config.

Checklist:

  • [x] I have run python util/check_style.py --apply to apply Open3D code style to my code.
  • [ ] This PR changes Open3D behavior or adds new functionality.
    • [ ] Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is updated accordingly.
    • [ ] I have added or updated C++ and / or Python unit tests OR included test results (e.g. screenshots or numbers) here.
  • [x ] I will follow up and update the code if CI fails.
  • [ ] For fork PRs, I have selected Allow edits from maintainers.

Description


This change is Reviewable

yuecideng avatar Feb 18 '23 14:02 yuecideng

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

update-docs[bot] avatar Feb 18 '23 14:02 update-docs[bot]

Previously, Open3D builds wheel with both cpu and cuda, so there are two folder cpu and cuda inside the wheel produced in CI. For static library, it is ok for user to import (with or without cuda in the machine). Now we want to use shared library, what is the best way to organize the folder structure such that we can achieve the same behaviour? @yxlao @ssheorey

yuecideng avatar Feb 18 '23 14:02 yuecideng