ipykernel icon indicating copy to clipboard operation
ipykernel copied to clipboard

Release 7.0

Open blink1073 opened this issue 1 year ago • 10 comments

main is currently targeting ipykernel 7.0, with support for AnyIO.

We have to address the following before releasing:

  • [x] inprocess tests are failing after #1079, and are currently skipped
  • [ ] jupyter_client tests are failing. We will need to make a release that supports both ipykernel 6.0 and 7.0
  • [ ] qtconsoletests are failing. We will need to make a release that supports both ipykernel 6.0 and 7.0, or a release that pins to (<7.0).
  • [x] Minimum Version tests are failing. We will need to update minimum versions to get that passing.
  • [x] Pin to (<7.0) in metakernel for now - https://github.com/Calysto/metakernel/issues/275
  • [ ] Add migration documentation (it might be helpful to write this while updating Metakernel)

blink1073 avatar Mar 22 '24 17:03 blink1073

cc @davidbrochart @ccordoba12

blink1073 avatar Mar 22 '24 17:03 blink1073

cc @ianthomas23

blink1073 avatar Mar 22 '24 17:03 blink1073

inprocess tests are failing after https://github.com/ipython/ipykernel/pull/1079, and are currently skipped

Perhaps this is the reason why Qtconsole tests are failing because it supports an in-process frontend.

spyder_kernels tests are failing. We will need to make a release that supports both ipykernel 6.0 and 7.0

We have an upper constraint on IPykernel (< 7.0), so we'll only need to add support for ipykernel 7.0 in a minor Spyder-kernels release.

ccordoba12 avatar Mar 22 '24 22:03 ccordoba12

Perhaps this is the reason why Qtconsole tests are failing because it supports an in-process frontend.

Good to know, thanks. If not, we can pin Qtconsole to (<7.0) as well.

For jupyter_client, I think it is a matter of updating the tests only, which use classes from ipykernel.

blink1073 avatar Mar 23 '24 18:03 blink1073

I started looking at the jupyter-client tests, test_start_sequence_kernels at least will be fixed by https://github.com/agronholm/anyio/pull/714.

davidbrochart avatar Apr 22 '24 12:04 davidbrochart

I'm stepping down from maintenance, so I won't be able to complete this release.

blink1073 avatar Aug 24 '24 01:08 blink1073

Listing some of the changes:

  • start_kernel is now async, and need to be awaited in a couple of places. Both in this repository and qtconsole.
  • we coudl add --enable-error-code unused-awaitable to mypy.
  • It looks like ipykernel test infratructure set ._is_test in conftext.py, which is not used in qtconsole. Not sure how to do that.
  • I'm wondering if some of the newest subshell things did not break some assumptions. They seem to make start_kernel blocking.

Carreau avatar Oct 14 '24 09:10 Carreau

Would it be OK to drop Python 3.8 for this release? It reached end-of-life on 2024-10-07.

ianthomas23 avatar Oct 25 '24 08:10 ianthomas23

Yes I think so.

davidbrochart avatar Oct 25 '24 08:10 davidbrochart

For what it is worth, IPython follows spec-0000 so IPython is going to drop 3.10 soon.

Carreau avatar Oct 25 '24 09:10 Carreau