js-kubo-rpc-client fix: export createKuboRPCClient function

fix: export createKuboRPCClient function

Open achingbrain opened this issue 1 year ago • 5 comments

The create function is too generic, it often clashes with other functions so export a copy with a more obvious name.

Apr 19 '24 10:04 achingbrain

We should update readme too

Apr 19 '24 11:04 SgtPooki

I don't know if we want something more pithy - createKuboClient or something?

Apr 19 '24 12:04 achingbrain

I think whatever works is fine. Im not a fan of uppercase acronyms in camel/pascal case "RPCClient" but its not something we need to type much

Apr 19 '24 13:04 SgtPooki

Also, This is technically a breaking change, but we did just release as v14 🤔

Apr 19 '24 14:04 SgtPooki

It’s not breaking because it’s a re-export of the existing symbol, not a straight rename so all good on that front.

Apr 19 '24 17:04 achingbrain

:tada: This PR is included in version 4.1.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

Sep 12 '24 10:09 github-actions[bot]