ipfs-webui icon indicating copy to clipboard operation
ipfs-webui copied to clipboard

feat: track remote pins in progress

Open hacdias opened this issue 3 years ago • 14 comments

Closes #1752 Closes #1991

  • [x] Persistance via persistActions
  • [x] Breathing cloud when pending
  • [x] Red cloud when failed
  • [x] Periodic checks per storage with back-off
  • [x] Dismiss failed pin when clicking red cloud (failed)
  • [x] Replace /pins by a list of pending and done pin jobs that can be cleared (similar to the upload drawer)

There are some things you can test via the Storybook. However, there are some aspects, such as dismissing a failed pin on the Files page that I wasn't able to test.

hacdias avatar Apr 08 '22 11:04 hacdias

A quick update on the pins statuses:

Screenshot 2022-04-27 at 12 04 37

hacdias avatar Apr 27 '22 10:04 hacdias

@hacdias mind resolving conflicts? I think we should review and ship this, so this work is not lost.

lidel avatar Jul 02 '22 23:07 lidel

@juliaxbow another one for you

SgtPooki avatar Jul 09 '22 07:07 SgtPooki

I tried running this locally and got the following error in the following scenarios:

  1. no daemon running
  2. daemon running, then trying to open the "set pinning" modal

image

I have a few changes coming up that resolve these errors.

Note that I added estuary, so I have three pinning services, and no matter what I do, selecting 'estuary' and applying in the "set pinning modal" and then re-opening it, always leaves estuary unchecked:

image

SgtPooki avatar Jul 18 '22 18:07 SgtPooki

@SgtPooki I think I fixed the issue you were having with the checkbox.

hacdias avatar Jul 22 '22 12:07 hacdias

Regarding the UI element to navigate to the Pins page: I would like to add something that would fit in. However, I'm not having great ideas.

image

Problem: the remanning information blocks on this style are not clickable.

image

Problem: better, as the button indicates an action. However, we do not usually use buttons for navigation, so it also does not feel natural.

image

I pushed the one below, but it doesn't make me necessarily happy. I just feel like it's still a bit out of place too.

image

What do you think?

Note: the icon only shows up if there's some pending, failed, or completed pins that were not dismissed (aka, the pin page is not empty).

hacdias avatar Aug 02 '22 14:08 hacdias

Tweaked the interface to include an 'x' for all types of pins:

image

hacdias avatar Aug 04 '22 08:08 hacdias

Thanks @hacdias!

@juliaxbow any suggestions on what could be the best way to indicate "there are remote pins in progress"? Design requirement: we want it to be visually noticeable, so the user won't miss the fact there are pinning jobs in progress. See initial mockups in https://github.com/ipfs/ipfs-webui/pull/1919#issuecomment-1202685324

lidel avatar Aug 04 '22 12:08 lidel

I like the idea of a breathing cloud! Something like below. Tested this on two people who both were inclined to click the cloud Pinning Cloud

Separately I would also suggest an additional visual clue (aside from color) for failed pin to make it more accessible for users. Like this Broken Pin or the more straightforward version (which I prefer): Failed Pin

juliaxbow avatar Aug 05 '22 01:08 juliaxbow

I updated the breathing cloud to match your idea:

Regarding the icon for the failed pins: I think it'd be a great addition, but maybe we should add it to https://github.com/ipfs-shipyard/ipfs-css first. /cc @lidel

hacdias avatar Aug 08 '22 08:08 hacdias

@juliaxbow could you please send the bottom icon (cloud with the slash) as an SVG so I can add it to the ipfs-css repository? You can see how the other icons are formatted and sizes, here: https://github.com/ipfs-shipyard/ipfs-css/tree/main/icons

hacdias avatar Aug 11 '22 07:08 hacdias

@hacdias added here

juliaxbow avatar Aug 17 '22 04:08 juliaxbow

I added the new icon in #2008 @lidel @SgtPooki. Please review and merge that PR into this one.

hacdias avatar Aug 18 '22 12:08 hacdias

@lidel @SgtPooki this PR is ready for review. It already includes the new icon.

hacdias avatar Sep 01 '22 12:09 hacdias

@SgtPooki I created some follow up issues (#2043 #2042) according to your comments. Once CI is green, I will be merging this.

hacdias avatar Oct 03 '22 08:10 hacdias

@SgtPooki it seems I need a new approval for this to go through 😄

hacdias avatar Oct 03 '22 09:10 hacdias

I do not understand. There are no pending changes requested, but I still can't merge.

Uploading Screenshot 2022-10-03 at 21.57.53.png…

hacdias avatar Oct 03 '22 19:10 hacdias

Ah, @lidel requested changes at some point so we also need @lidel's review.

hacdias avatar Oct 03 '22 19:10 hacdias

:tada: This PR is included in version 2.20.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

ipfs-gui-bot avatar Nov 09 '22 23:11 ipfs-gui-bot