js-ipfs-http-client icon indicating copy to clipboard operation
js-ipfs-http-client copied to clipboard

fix: files ls inconsisntency

Open hacdias opened this issue 7 years ago • 4 comments

It is stated on interface-ipfs-core that files.ls type's must be strings (file or directory).

Tests: https://github.com/ipfs/interface-ipfs-core/pull/282

hacdias avatar May 23 '18 16:05 hacdias

@alanshaw what do you think about this?

hacdias avatar Aug 04 '18 12:08 hacdias

@alanshaw what's the state of this PR? The same for https://github.com/ipfs/interface-js-ipfs-core/pull/282

hacdias avatar Feb 26 '19 07:02 hacdias

@hacdias did you see the comments here https://github.com/ipfs/interface-js-ipfs-core/pull/282#discussion_r232642237 ?

alanshaw avatar Mar 11 '19 09:03 alanshaw

@alanshaw I believe I missed it!! Just read the comments. I'll work on those points. I'll close this PR as soon as I open a new one since this is a bit out of date.

hacdias avatar Mar 11 '19 09:03 hacdias