interface-js-ipfs-core icon indicating copy to clipboard operation
interface-js-ipfs-core copied to clipboard

Published 20 hours ago • verified publisher icon ipfs-inactive

dedupe tests

Open hugomrdias opened this issue 5 years ago • 4 comments

This PR supports the deduping of tests in ipfs-http-client and js-ipfs.

Tests will be added here and removed in both repos.

changes to subsystems

  • dag.get
  • ping
  • mfs.ls
  • add

refs: https://github.com/ipfs/js-ipfs-http-client/pull/1200 https://github.com/ipfs/js-ipfs/pull/2669

hugomrdias avatar Dec 12 '19 16:12 hugomrdias

Is there some way of comparing coverage before/after to make sure nothing is missed in these PRs?

achingbrain avatar Dec 13 '19 18:12 achingbrain

Yes check codecov in the http-client PR apparently we lost these 2 bits https://codecov.io/gh/ipfs/js-ipfs-http-client/compare/23421f397e4ae80ac9e9264ee6662b2cc0e34791...2e30f994459a038fc4665890101a23beafcd0f71/changes

hugomrdias avatar Dec 13 '19 18:12 hugomrdias

In js-ipfs codecov/project Absolute coverage decreased by -0.82% but relative coverage increased by +11.8% compared to 6395730

And the follow up cli tests PRs will increase the cov more.

hugomrdias avatar Dec 13 '19 18:12 hugomrdias

added a new test for the validation in dag.get

hugomrdias avatar Dec 13 '19 20:12 hugomrdias