iotex-core icon indicating copy to clipboard operation
iotex-core copied to clipboard

Disable special address

Open dustinxie opened this issue 11 months ago • 2 comments

Description

Special address (rewarding pool and staking bucket pool) is not allowed as transaction address

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [x] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [x] make test
  • [x] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

dustinxie avatar Jan 03 '25 01:01 dustinxie

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.96%. Comparing base (436e4d1) to head (bdb7adf). Report is 65 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4537      +/-   ##
==========================================
- Coverage   74.83%   72.96%   -1.88%     
==========================================
  Files         378      385       +7     
  Lines       31624    32904    +1280     
==========================================
+ Hits        23666    24007     +341     
- Misses       6747     7664     +917     
- Partials     1211     1233      +22     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 13 '25 23:01 codecov[bot]