iotex-core icon indicating copy to clipboard operation
iotex-core copied to clipboard

[db] implement Get/Put/Delete/Version() for BoltDBVersioned

Open dustinxie opened this issue 1 year ago • 2 comments

Description

as title, implement 4 methos for versioned DB.

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [x] make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

dustinxie avatar Apr 26 '24 01:04 dustinxie

Codecov Report

Attention: Patch coverage is 90.00000% with 19 lines in your changes missing coverage. Please review.

Project coverage is 76.76%. Comparing base (cc526cd) to head (e8c1e97). Report is 43 commits behind head on master.

:exclamation: Current head e8c1e97 differs from pull request most recent head d651871

Please upload reports for the commit d651871 to get more accurate results.

Files Patch % Lines
db/db_versioned.go 86.82% 16 Missing and 1 partial :warning:
db/db_versioned_util.go 96.72% 1 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4256      +/-   ##
==========================================
- Coverage   77.02%   76.76%   -0.27%     
==========================================
  Files         342      347       +5     
  Lines       29406    29415       +9     
==========================================
- Hits        22651    22581      -70     
- Misses       5650     5737      +87     
+ Partials     1105     1097       -8     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 03 '24 02:05 codecov[bot]

Quality Gate Failed Quality Gate failed

Failed conditions
6.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Jul 29 '24 00:07 sonarqubecloud[bot]

Quality Gate Failed Quality Gate failed

Failed conditions
5.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

sonarqubecloud[bot] avatar Dec 09 '24 06:12 sonarqubecloud[bot]