iotex-core icon indicating copy to clipboard operation
iotex-core copied to clipboard

[action] Web3 for CandidateActivate and CandidateEndorsement

Open envestcc opened this issue 1 year ago • 1 comments

Description

This pull request adds support for the web3 in the candidateActivate and candidateEndorsement actions.

Type of change

Please delete options that are not relevant.

  • [x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [] make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

envestcc avatar Feb 08 '24 14:02 envestcc

=== RUN   TestRlpDecodeVerify
    rlp_tx_test.go:99: 
        	Error Trace:	/home/runner/work/iotex-core/iotex-core/action/rlp_tx_test.go:99
        	Error:      	Received unexpected error:
        	            	invalid key format
        	            	github.com/iotexproject/go-pkgs/crypto.init
        	            		/home/runner/go/pkg/mod/github.com/iotexproject/[email protected]/crypto/key.go:38
        	            	runtime.doInit
        	            		/opt/hostedtoolcache/go/1.19.12/x64/src/runtime/proc.go:6331
        	            	runtime.doInit
        	            		/opt/hostedtoolcache/go/1.19.12/x64/src/runtime/proc.go:6308
        	            	runtime.doInit
        	            		/opt/hostedtoolcache/go/1.19.12/x64/src/runtime/proc.go:6308
        	            	runtime.main
        	            		/opt/hostedtoolcache/go/1.19.12/x64/src/runtime/proc.go:[233](https://github.com/iotexproject/iotex-core/actions/runs/7831212883/job/21367007708?pr=4140#step:5:234)
        	            	runtime.goexit
        	            		/opt/hostedtoolcache/go/1.19.12/x64/src/runtime/asm_amd64.s:1594
        	Test:       	TestRlpDecodeVerify

CoderZhi avatar Feb 28 '24 11:02 CoderZhi

Codecov Report

Attention: Patch coverage is 89.47368% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 76.15%. Comparing base (e1f0636) to head (0597d63). Report is 195 commits behind head on master.

Files Patch % Lines
action/candidate_endorsement.go 84.21% 3 Missing and 3 partials :warning:
action/candidate_activate.go 94.11% 1 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4140      +/-   ##
==========================================
+ Coverage   75.38%   76.15%   +0.77%     
==========================================
  Files         303      340      +37     
  Lines       25923    29055    +3132     
==========================================
+ Hits        19541    22126    +2585     
- Misses       5360     5828     +468     
- Partials     1022     1101      +79     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 07 '24 12:03 codecov[bot]

Quality Gate Failed Quality Gate failed

Failed conditions
5.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Mar 11 '24 17:03 sonarqubecloud[bot]